[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

src/runtime/runtime-compiler.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/arguments.h"
 #include "src/asmjs/asm-js.h"
 #include "src/compiler.h"
 #include "src/deoptimizer.h"
@@ skipping 75 matching lines @@
   CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);
 
   Handle<JSObject> foreign;
   if (args[2]->IsJSObject()) {
     foreign = args.at<i::JSObject>(2);
   }
   Handle<JSArrayBuffer> memory;
   if (args[3]->IsJSArrayBuffer()) {
     memory = args.at<i::JSArrayBuffer>(3);
   }
-  if (args[1]->IsJSObject() && function->shared()->HasAsmWasmData()) {
+  if (args[1]->IsJSObject() && function->shared()->HasAsmWasmData() &&
+      AsmJs::IsStdlibValid(isolate, handle(function->shared()->asm_wasm_data()),
+                           args.at<JSObject>(1))) {

[titzer, 2016/08/19 10:00:28]

Does that need to be args.at<JSReceiver>?

[bradn, 2016/08/19 17:29:08]

Done.

     MaybeHandle<Object> result;
     result = AsmJs::InstantiateAsmWasm(
         isolate, handle(function->shared()->asm_wasm_data()), memory, foreign);
     if (!result.is_null()) {
       return *result.ToHandleChecked();
     }
   }
   // Remove wasm data, mark as broken for asm->wasm,
   // replace code with CompileLazy, and return a smi 0 to indicate failure.
   if (function->shared()->HasAsmWasmData()) {
@@ skipping 334 matching lines @@
   DCHECK(is_valid_language_mode(args.smi_at(3)));
   LanguageMode language_mode = static_cast<LanguageMode>(args.smi_at(3));
   DCHECK(args[4]->IsSmi());
   Handle<SharedFunctionInfo> outer_info(args.at<JSFunction>(2)->shared(),
                                         isolate);
   return CompileGlobalEval(isolate, args.at<String>(1), outer_info,
                            language_mode, args.smi_at(4), args.smi_at(5));
 }
 }  // namespace internal
 }  // namespace v8