src/asmjs/asm-typer.cc - Issue 2251433002: [wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/asmjs/asm-typer.cc

Issue 2251433002: [wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/asmjs/asm-typer.cc

diff --git a/src/asmjs/asm-typer.cc b/src/asmjs/asm-typer.cc

index bdd657f8f1bf73ade9e0b7014c90367a38bf5a6b..88879ab84d4a190c6954bcecdf41e1543d521e1d 100644

--- a/src/asmjs/asm-typer.cc

+++ b/src/asmjs/asm-typer.cc

@@ -428,7 +428,9 @@ AsmTyper::StandardMember AsmTyper::VariableAsStandardMember(Variable* var) {

if (var_info == nullptr) {

return kNone;

}

- return var_info->standard_member();

+ StandardMember member = var_info->standard_member();

+ stdlib_uses_.insert(member);

+ return member;

}

bool AsmTyper::Validate() {

« no previous file with comments | « src/asmjs/asm-typer.h ('k') | src/runtime/runtime-compiler.cc » ('j') | no next file with comments »