Issue 2251393002: Revert of Round GPU tiles to multiple of 64 to work around CA scaling issues

Issue 2251393002: Revert of Round GPU tiles to multiple of 64 to work around CA scaling issues (Closed)

Created:
4 years, 4 months ago by rjwright

Modified:
4 years, 4 months ago

Reviewers:
vmpstr, ericrk

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Round GPU tiles to multiple of 64 to work around CA scaling issues (patchset #3 id:40001 of https://codereview.chromium.org/2251583002/ ) Reason for revert: virtual/gpu-rasterization/fast/images/color-profile-layer.html virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html virtual/gpu-rasterization/fast/images/color-profile-group.html are failing on Win10/Win7 bots after auto-rebaseline. crbug.com/638822 Original issue's description: > Round GPU tiles to multiple of 64 to work around CA scaling issues > > When scaling tiles using Core Animation, certain tile sizes / scale > factors appear to cause rounding issues and seams between tiles. > > Rounding tiles to a multiple of 64 works around the > most obvious case of this, which is seen on the print preview screen. > > BUG=632274 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel > > Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3 > Cr-Commit-Position: refs/heads/master@{#412698} TBR=vmpstr@chromium.org,ericrk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632274

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -21 lines)			Patch
M	cc/layers/picture_layer_impl.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	cc/layers/picture_layer_impl_unittest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rjwright

Created Revert of Round GPU tiles to multiple of 64 to work around CA scaling ...

4 years, 4 months ago (2016-08-18 05:41:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251393002/1

4 years, 4 months ago (2016-08-18 05:41:29 UTC) #3

commit-bot: I haz the power

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...

4 years, 4 months ago (2016-08-18 05:42:01 UTC) #5

rjwright

4 years, 4 months ago (2016-08-18 06:01:52 UTC) #6

On 2016/08/18 05:42:01, commit-bot: I haz the power wrote:
> Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
> While running git apply --index -3 -p1;
>   error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1315
>   error: repository lacks the necessary blob to fall back on 3-way merge.
>   error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply
> 
> Patch:       third_party/WebKit/LayoutTests/TestExpectations
> Index: third_party/WebKit/LayoutTests/TestExpectations
> diff --git a/third_party/WebKit/LayoutTests/TestExpectations
> b/third_party/WebKit/LayoutTests/TestExpectations
> index
>
ccf7d8bfd8c7fa811f9ba0bb30ee0987850ca2c3..e9e2f89e1797cd8010f84d3a2b812ad35a7480b9
> 100644
> --- a/third_party/WebKit/LayoutTests/TestExpectations
> +++ b/third_party/WebKit/LayoutTests/TestExpectations
> @@ -1315,13 +1315,3 @@
>  crbug.com/490015
> virtual/stable/http/tests/navigation/beacon-blob-with-non-simple-type.html [
> Skip ]
>  # This test fails with the stable release mode.
>  crbug.com/490015
> virtual/stable/http/tests/navigation/same-and-different-back.html [ Skip ]
> -
> -crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-layer.html
> [ NeedsRebaseline ]
> -crbug.com/632274
> virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html [
> NeedsRebaseline ]
> -crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-group.html
> [ NeedsRebaseline ]
> -crbug.com/632274 virtual/gpu-rasterization/fast/images/182.html [
> NeedsRebaseline ]
> -crbug.com/632274 virtual/gpu-rasterization/fast/images/23-55.html [
> NeedsRebaseline ]
> -crbug.com/632274
> virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html
[
> NeedsRebaseline ]
> -crbug.com/632274 virtual/gpu-rasterization/fast/images/55.html [
> NeedsRebaseline ]
> -crbug.com/632274 virtual/gpu-rasterization/fast/images/12-55.html [
> NeedsRebaseline ]
> -crbug.com/632274 virtual/gpu-rasterization/fast/images/2-dht.html [
> NeedsRebaseline ]

Manually reverted here : https://codereview.chromium.org/2251863005

rjwright

4 years, 4 months ago (2016-08-18 06:02:07 UTC) #7

Description was changed from

==========
Revert of Round GPU tiles to multiple of 64 to work around CA scaling issues
(patchset #3 id:40001 of https://codereview.chromium.org/2251583002/ )

Reason for revert:
virtual/gpu-rasterization/fast/images/color-profile-layer.html
virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html
virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html
virtual/gpu-rasterization/fast/images/color-profile-group.html

are failing on Win10/Win7 bots after auto-rebaseline.

crbug.com/638822


Original issue's description:
> Round GPU tiles to multiple of 64 to work around CA scaling issues
> 
> When scaling tiles using Core Animation, certain tile sizes / scale
> factors appear to cause rounding issues and seams between tiles.
> 
> Rounding tiles to a multiple of 64 works around the
> most obvious case of this, which is seen on the print preview screen.
> 
> BUG=632274
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel
> 
> Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3
> Cr-Commit-Position: refs/heads/master@{#412698}

TBR=vmpstr@chromium.org,ericrk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632274
==========

to

==========
Revert of Round GPU tiles to multiple of 64 to work around CA scaling issues
(patchset #3 id:40001 of https://codereview.chromium.org/2251583002/ )

Reason for revert:
virtual/gpu-rasterization/fast/images/color-profile-layer.html
virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html
virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html
virtual/gpu-rasterization/fast/images/color-profile-group.html

are failing on Win10/Win7 bots after auto-rebaseline.

crbug.com/638822


Original issue's description:
> Round GPU tiles to multiple of 64 to work around CA scaling issues
> 
> When scaling tiles using Core Animation, certain tile sizes / scale
> factors appear to cause rounding issues and seams between tiles.
> 
> Rounding tiles to a multiple of 64 works around the
> most obvious case of this, which is seen on the print preview screen.
> 
> BUG=632274
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel
> 
> Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3
> Cr-Commit-Position: refs/heads/master@{#412698}

TBR=vmpstr@chromium.org,ericrk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632274
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages