Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2251863005: Manually revert 2251583002 (Closed)

Created:
4 years, 4 months ago by rjwright
Modified:
4 years, 4 months ago
Reviewers:
sashab, vmpstr, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually revert 2251583002 Manually revert all of https://codereview.chromium.org/2251583002/. NeedsRebaseline tags were removed by rebaseline-o-matic - adding them back to reset test expectations to former state. Replaces https://codereview.chromium.org/2251393002/ which could not auto-merge BUG=638822 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=ericrk@chromium.org,vmpstr@chromium.org Committed: https://crrev.com/524ac838e48fa8d291d6dfbb63ac6395d55eb533 Cr-Commit-Position: refs/heads/master@{#412762}

Patch Set 1 #

Patch Set 2 : add back rebaseline tags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rjwright
4 years, 4 months ago (2016-08-18 06:09:14 UTC) #6
sashab
Yup lgtm, did you want to add the TestExpectations back too to be rebaselined? Otherwise ...
4 years, 4 months ago (2016-08-18 06:10:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251863005/20001
4 years, 4 months ago (2016-08-18 06:18:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 08:10:46 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:13:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/524ac838e48fa8d291d6dfbb63ac6395d55eb533
Cr-Commit-Position: refs/heads/master@{#412762}

Powered by Google App Engine
This is Rietveld 408576698