third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

index e1d5c4bf70f973b10614f9ae43618dc488c1074d..09fd91de288b7b327d95a1ac55eba6af83aa878f 100644

--- a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

+++ b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h

@@ -57,8 +57,10 @@ public:

void setBottomOffset(float offset) { m_bottomOffset = offset; }

void setScrollContainerRelativeContainingBlockRect(const FloatRect& rect) { m_scrollContainerRelativeContainingBlockRect = rect; }

+ const FloatRect& scrollContainerRelativeContainingBlockRect() const { return m_scrollContainerRelativeContainingBlockRect; }

void setScrollContainerRelativeStickyBoxRect(const FloatRect& rect) { m_scrollContainerRelativeStickyBoxRect = rect; }

+ const FloatRect& scrollContainerRelativeStickyBoxRect() const { return m_scrollContainerRelativeStickyBoxRect; }

bool operator==(const StickyPositionScrollingConstraints& other) const

{

@@ -73,11 +75,6 @@ public:

bool operator!=(const StickyPositionScrollingConstraints& other) const { return !(*this == other); }

private:

- friend class LayoutBoxModelObjectTest;

- const FloatRect& scrollContainerRelativeContainingBlockRect() const { return m_scrollContainerRelativeContainingBlockRect; }

- const FloatRect& scrollContainerRelativeStickyBoxRect() const { return m_scrollContainerRelativeStickyBoxRect; }

AnchorEdges m_anchorEdges;

float m_leftOffset;

float m_rightOffset;