third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index b2398cfabdae21dd6adc77131fb41536cdf0eef2..9c628e661b2936cda0c21c7fbf4a1b6705c56891 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -1032,8 +1032,6 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co

if (frameView->hasBackgroundAttachmentFixedObjects())

reasons |= MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;

- if (frameView->hasStickyPositionObjects())

- reasons |= MainThreadScrollingReason::kHasStickyPositionObjects;

FrameView::ScrollingReasons scrollingReasons = frameView->getScrollingReasons();

const bool mayBeScrolledByInput = (scrollingReasons == FrameView::Scrollable);

const bool mayBeScrolledByScript = mayBeScrolledByInput || (scrollingReasons ==