third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h ('k') | third_party/WebKit/Source/platform/graphics/CompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js b/third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

index 66d95ed7df433fcbe6bcaefa37b93defad637960..2d995800950d2c227410f7030230ee3115554456 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js

@@ -64,9 +64,7 @@ WebInspector.LayerDetailsView.CompositingReasonDetail = {

"backfaceVisibilityHidden": WebInspector.UIString("Composition due to association with an element with a \"backface-visibility: hidden\" style."),

"animation": WebInspector.UIString("Composition due to association with an animated element."),

"filters": WebInspector.UIString("Composition due to association with an element with CSS filters applied."),

- "positionFixed": WebInspector.UIString("Composition due to association with an element with a \"position: fixed\" style."),

- // FIXME: Can we remove this entry now that position: sticky has been removed?

- "positionSticky": WebInspector.UIString("Composition due to association with an element with a \"position: sticky\" style."),

+ "scrollDependentPosition": WebInspector.UIString("Composition due to association with an element with a \"position: fixed\" or \"position: sticky\" style."),

"overflowScrollingTouch": WebInspector.UIString("Composition due to association with an element with a \"overflow-scrolling: touch\" style."),

"blending": WebInspector.UIString("Composition due to association with an element that has blend mode other than \"normal\"."),

"assumedOverlap": WebInspector.UIString("Composition due to association with an element that may overlap other composited elements."),