third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 2251303003: Implement position: sticky updates on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index 8ae2819e6a25525fb5c6aeba17bda724df869e7d..4e03bcb2021db03c50507f1deccbfb93c7f9924c 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -227,7 +227,7 @@ void CompositingRequirementsUpdater::updateRecursive(PaintLayer* ancestorLayer,

directReasons |= CompositingReasonVideoOverlay;

if (currentRecursionData.m_hasCompositedScrollingAncestor && layer->layoutObject()->styleRef().hasViewportConstrainedPosition())

- directReasons |= CompositingReasonPositionFixed;

+ directReasons |= CompositingReasonScrollDependentPosition;

bool canBeComposited = compositor->canBeComposited(layer);

if (canBeComposited) {