Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2251223002: blimp: Moved ImeFeature to blimp/client/core/contents (Closed)

Created:
4 years, 4 months ago by shaktisahu
Modified:
4 years, 4 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Moved ImeFeature to blimp/client/core/contents BUG=611111 Committed: https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8 Cr-Commit-Position: refs/heads/master@{#413257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -232 lines) Patch
M blimp/client/BUILD.gn View 5 chunks +0 lines, -7 lines 0 comments Download
M blimp/client/app/android/web_input_box.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/web_input_box.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M blimp/client/app/linux/blimp_client_session_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/contents/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
A + blimp/client/core/contents/ime_feature.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/ime_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/contents/mock_ime_feature_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + blimp/client/core/contents/mock_ime_feature_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/feature/ime_feature.h View 1 chunk +0 lines, -85 lines 0 comments Download
D blimp/client/feature/ime_feature.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D blimp/client/feature/mock_ime_feature_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/client/feature/mock_ime_feature_delegate.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M blimp/client/session/blimp_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/browser_tests/engine_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2258563003 Patch 1
Issue 2258563003 Patch 40001

Messages

Total messages: 12 (5 generated)
shaktisahu
4 years, 4 months ago (2016-08-18 20:24:04 UTC) #2
nyquist
lgtm
4 years, 4 months ago (2016-08-18 23:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251223002/1
4 years, 4 months ago (2016-08-19 02:13:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276697)
4 years, 4 months ago (2016-08-19 05:04:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251223002/1
4 years, 4 months ago (2016-08-19 20:16:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 21:47:41 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 21:50:20 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8
Cr-Commit-Position: refs/heads/master@{#413257}

Powered by Google App Engine
This is Rietveld 408576698