Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: blimp/client/feature/ime_feature.h

Issue 2251223002: blimp: Moved ImeFeature to blimp/client/core/contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/mock_ime_feature_delegate.cc ('k') | blimp/client/feature/ime_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/feature/ime_feature.h
diff --git a/blimp/client/feature/ime_feature.h b/blimp/client/feature/ime_feature.h
deleted file mode 100644
index 7de0ee08e83c3b95580a71ae588f10724cb3941c..0000000000000000000000000000000000000000
--- a/blimp/client/feature/ime_feature.h
+++ /dev/null
@@ -1,85 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef BLIMP_CLIENT_FEATURE_IME_FEATURE_H_
-#define BLIMP_CLIENT_FEATURE_IME_FEATURE_H_
-
-#include <map>
-#include <string>
-
-#include "base/macros.h"
-#include "blimp/net/blimp_message_processor.h"
-#include "ui/base/ime/text_input_type.h"
-
-namespace blimp {
-namespace client {
-
-// Handles all incoming and outgoing protobuf messages for text input of type
-// BlimpMessage::IME for blimp client.
-// Upon receiving a text input request from the engine, the ImeFeature caches
-// the |tab_id_| and |render_widget_id_| for the request and
-// delegates the request to the Delegate which then opens up the IME.
-// After user is done typing, the text is passed back to ImeFeature, which then
-// sends the text to the engine over network along with the same |tab_id_| and
-// |render_widget_id_|.
-// Any time user taps on an input text, ImeMessage::SHOW_IME message will be
-// sent to client. Similarly, any time the text input is out of focus (e.g. if
-// user navigates away from the currently page or the page loads for the first
-// time), ImeMessage::HIDE_IME will be sent.
-
-class ImeFeature : public BlimpMessageProcessor {
- public:
- // A delegate to be notified of text input requests.
- class Delegate {
- public:
- virtual ~Delegate() {}
- virtual void OnShowImeRequested(ui::TextInputType input_type,
- const std::string& text) = 0;
- virtual void OnHideImeRequested() = 0;
- };
-
- ImeFeature();
- ~ImeFeature() override;
-
- // Set the BlimpMessageProcessor that will be used to send BlimpMessage::IME
- // messages to the engine.
- void set_outgoing_message_processor(
- std::unique_ptr<BlimpMessageProcessor> processor) {
- outgoing_message_processor_ = std::move(processor);
- }
-
- // Sets a Delegate to be notified of all text input messages.
- // There must be a valid non-null Delegate set before routing messages
- // to the ImeFeature for processing, until the last message is processed.
- void set_delegate(Delegate* delegate) { delegate_ = delegate; }
-
- // Sends text from IME to the blimp engine.
- void OnImeTextEntered(const std::string& text);
-
- // BlimpMessageProcessor implementation.
- void ProcessMessage(std::unique_ptr<BlimpMessage> message,
- const net::CompletionCallback& callback) override;
-
- private:
- // Used to actually show or hide the IME. See notes on |set_delegate|.
- Delegate* delegate_ = nullptr;
-
- // Tab id and render widget id for the input field for which user input is
- // being requested.
- // The values are cached from the ImeMessage::SHOW_IME message and sent back
- // to engine in the subsequent ImeMessage::SET_TEXT message.
- // The cached values are cleared on receiving ImeMessage::HIDE_IME request.
- int tab_id_ = -1;
- int render_widget_id_ = 0;
-
- // Used to send BlimpMessage::IME messages to the engine.
- std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;
-
- DISALLOW_COPY_AND_ASSIGN(ImeFeature);
-};
-
-} // namespace client
-} // namespace blimp
-
-#endif // BLIMP_CLIENT_FEATURE_IME_FEATURE_H_
« no previous file with comments | « blimp/client/core/contents/mock_ime_feature_delegate.cc ('k') | blimp/client/feature/ime_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698