Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4012)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
index ce050c22395f4aa5741b04d2ea9ba96c8ece7362..e5865b582e79ae748147a5b3aa64658490549fc3 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
@@ -59,13 +59,13 @@ class ImmersiveRevealedLockAsh : public ImmersiveRevealedLock {
} // namespace
ImmersiveModeControllerAsh::ImmersiveModeControllerAsh()
- : controller_(new ash::ImmersiveFullscreenController),
+ : ImmersiveModeController(Type::ASH),
+ controller_(new ash::ImmersiveFullscreenController),
browser_view_(nullptr),
native_window_(nullptr),
observers_enabled_(false),
use_tab_indicators_(false),
- visible_fraction_(1) {
-}
+ visible_fraction_(1) {}
ImmersiveModeControllerAsh::~ImmersiveModeControllerAsh() {
EnableWindowObservers(false);
@@ -133,10 +133,6 @@ void ImmersiveModeControllerAsh::OnFindBarVisibleBoundsChanged(
find_bar_visible_bounds_in_screen_ = new_visible_bounds_in_screen;
}
-void ImmersiveModeControllerAsh::SetupForTest() {
- controller_->SetupForTest();
-}
-
void ImmersiveModeControllerAsh::EnableWindowObservers(bool enable) {
if (observers_enabled_ == enable)
return;

Powered by Google App Engine
This is Rietveld 408576698