chrome/browser/ui/views/frame/immersive_mode_controller_ash.h - Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

index a2133ce363171efed9d3617bcea31379ee34ae66..7e925353ed34173565a418354191284e531837da 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

@@ -29,6 +29,8 @@ class ImmersiveModeControllerAsh

ImmersiveModeControllerAsh();

~ImmersiveModeControllerAsh() override;

+ ash::ImmersiveFullscreenController* controller() { return controller_.get(); }

// ImmersiveModeController overrides:

void Init(BrowserView* browser_view) override;

void SetEnabled(bool enabled) override;

@@ -42,7 +44,6 @@ class ImmersiveModeControllerAsh

WARN_UNUSED_RESULT;

void OnFindBarVisibleBoundsChanged(

const gfx::Rect& new_visible_bounds_in_screen) override;

- void SetupForTest() override;

private:

// Enables or disables observers for window restore and entering / exiting