chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc - Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Issue 2251213004: Moves ImmersiveFullscreenController::SetupForTest into test class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

index b0d10e332c008255bd4fcfb9a0cc01bdf710d11d..8851cec7e950b9d4db7ac38708adffbdc606605f 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

@@ -11,6 +11,7 @@

#include "ash/shelf/shelf_layout_manager.h"

#include "ash/shell.h"

#include "ash/test/ash_test_base.h"

+#include "ash/test/immersive_fullscreen_controller_test_api.h"

#include "base/command_line.h"

#include "base/macros.h"

#include "chrome/app/chrome_command_ids.h"

@@ -18,6 +19,7 @@

#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"

#include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

+#include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"

#include "chrome/browser/ui/views/frame/test_with_browser_view.h"

#include "chrome/browser/ui/views/frame/top_container_view.h"

#include "chrome/browser/ui/views/tabs/tab_strip.h"

@@ -40,7 +42,10 @@ class ImmersiveModeControllerAshTest : public TestWithBrowserView {

browser()->window()->Show();

controller_ = browser_view()->immersive_mode_controller();

- controller_->SetupForTest();

+ ASSERT_EQ(ImmersiveModeController::Type::ASH, controller_->type());

+ ash::ImmersiveFullscreenControllerTestApi(

+ static_cast<ImmersiveModeControllerAsh*>(controller_)->controller())

+ .SetupForTest();

}

// Returns the bounds of |view| in widget coordinates.