Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Instead take a local matrix parameter.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2250563004

Committed: https://skia.googlesource.com/skia/+/e4f2461113806e3080aeb8bc5637e82d1b3d8295

[bsalomon, 2016-08-17 15:22:03]

Description was changed from

==========
Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Instead take a local matrix parameter.
==========

to

==========
Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Instead take a local matrix parameter.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2250563004
==========

[bsalomon, 2016-08-17 15:25:23]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-08-17 15:25:23]

Follow up to the other cleanup CL.

[bsalomon, 2016-08-17 16:21:32]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 16:21:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-17 16:27:25]

lgtm

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/GrDefaultGeoPro...
File src/gpu/GrDefaultGeoProcFactory.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/GrDefaultGeoPro...
src/gpu/GrDefaultGeoProcFactory.cpp:55: const SkMatrix& viewMatrix() const {
return fViewMatrix; }
Do we still need this ?

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAACon...
File src/gpu/batches/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAACon...
src/gpu/batches/GrAAConvexPathRenderer.cpp:541: bool colorIgnored() const {
return GrColor_ILLEGAL == fColor; }
??

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAnaly...
File src/gpu/batches/GrAnalyticRectBatch.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAnaly...
src/gpu/batches/GrAnalyticRectBatch.cpp:72: 
??

[bsalomon, 2016-08-17 16:33:00]

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/GrDefaultGeoPro...
File src/gpu/GrDefaultGeoProcFactory.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/GrDefaultGeoPro...
src/gpu/GrDefaultGeoProcFactory.cpp:55: const SkMatrix& viewMatrix() const {
return fViewMatrix; }
On 2016/08/17 16:27:25, robertphillips wrote:
> Do we still need this ?

All of these getters are still used in emitCode. That can be cleaned up
separately.

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAACon...
File src/gpu/batches/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAACon...
src/gpu/batches/GrAAConvexPathRenderer.cpp:541: bool colorIgnored() const {
return GrColor_ILLEGAL == fColor; }
On 2016/08/17 16:27:25, robertphillips wrote:
> ??

same, still used in emitCode()

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAnaly...
File src/gpu/batches/GrAnalyticRectBatch.cpp (right):

https://codereview.chromium.org/2250563004/diff/20001/src/gpu/batches/GrAnaly...
src/gpu/batches/GrAnalyticRectBatch.cpp:72: 
On 2016/08/17 16:27:25, robertphillips wrote:
> ??

same

[commit-bot: I haz the power, 2016-08-17 17:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 17:13:54]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-08-17 17:28:55]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-08-17 17:29:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 17:30:20]

Description was changed from

==========
Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Instead take a local matrix parameter.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2250563004
==========

to

==========
Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Instead take a local matrix parameter.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2250563004

Committed:
https://skia.googlesource.com/skia/+/e4f2461113806e3080aeb8bc5637e82d1b3d8295
==========

[commit-bot: I haz the power, 2016-08-17 17:30:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e4f2461113806e3080aeb8bc5637e82d1b3d8295