src/gpu/effects/GrBezierEffect.cpp - Issue 2250563004: Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrBezierEffect.cpp

Issue 2250563004: Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper() (Closed) Base URL: https://chromium.googlesource.com/skia.git@clean

Patch Set: simplify Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrBezierEffect.cpp

diff --git a/src/gpu/effects/GrBezierEffect.cpp b/src/gpu/effects/GrBezierEffect.cpp

index 9d3e8eec4fb368481d0ca2d08f1d00506241fae3..1904b203dfb9e3d91a3dd1769e0a40ae7acad28c 100644

--- a/src/gpu/effects/GrBezierEffect.cpp

+++ b/src/gpu/effects/GrBezierEffect.cpp

@@ -53,7 +53,8 @@ public:

const GrGLSLProgramDataManager& pdman,

int index,

const SkTArray<const GrCoordTransform*, true>& transforms) override {

- this->setTransformDataHelper<GrConicEffect>(primProc, pdman, index, transforms);

+ this->setTransformDataHelper(primProc.cast<GrConicEffect>().localMatrix(), pdman, index,

+ transforms);

}

private:

@@ -327,7 +328,8 @@ public:

const GrGLSLProgramDataManager& pdman,

int index,

const SkTArray<const GrCoordTransform*, true>& transforms) override {

- this->setTransformDataHelper<GrQuadEffect>(primProc, pdman, index, transforms);

+ this->setTransformDataHelper(primProc.cast<GrQuadEffect>().localMatrix(), pdman, index,

+ transforms);

}

private:

« src/gpu/batches/GrAnalyticRectBatch.cpp ('K') | « src/gpu/batches/GrPLSPathRenderer.cpp ('k') | src/gpu/effects/GrBitmapTextGeoProc.cpp » ('j') | no next file with comments »