Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2253903002: Minor cleanup of GP classes in GrOvalRenderer (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor cleanup of GP classes in GrOvalRenderer Move GLSL nested classes to private and remove unnecessary public getters. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253903002 Committed: https://skia.googlesource.com/skia/+/31df31c12fe2ce2a6688f226dd3ea24c06999f63

Patch Set 1 #

Patch Set 2 : fix whitespace #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -61 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 14 chunks +48 lines, -61 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
bsalomon
https://codereview.chromium.org/2253903002/diff/20001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (left): https://codereview.chromium.org/2253903002/diff/20001/src/gpu/GrOvalRenderer.cpp#oldcode91 src/gpu/GrOvalRenderer.cpp:91: const SkMatrix& localMatrix() const { return fLocalMatrix; } This ...
4 years, 4 months ago (2016-08-17 15:02:39 UTC) #3
robertphillips
lgtm
4 years, 4 months ago (2016-08-17 15:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253903002/20001
4 years, 4 months ago (2016-08-17 15:59:31 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:00:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/31df31c12fe2ce2a6688f226dd3ea24c06999f63

Powered by Google App Engine
This is Rietveld 408576698