Type->String helper function added to WebInputEvent.

Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned up.
The helper function is called in TestPlugin::handleInputEvent instead of re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
Committed: https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c
Cr-Commit-Position: refs/heads/master@{#414580}

[sahel, 2016-08-16 20:32:34]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 20:32:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2016-08-16 20:34:16]

sahel@chromium.org changed reviewers:
+ mustaq@chromium.org

[dtapuska, 2016-08-16 21:02:40]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2016-08-16 21:02:40]

https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebInputEvent.h (right):

https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebInputEvent.h:263: static const char*
GetName(WebInputEvent::Type type)
Can you move this implementation into the cpp file? That way we won't get
multiple copies in the different compilation units.

[commit-bot: I haz the power, 2016-08-16 21:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:18:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2016-08-16 21:32:25]

nick@chromium.org changed reviewers:
+ chongz@chromium.org

[ncarter (slow), 2016-08-16 21:32:25]

fyi, this is going to be in conflict with
https://codereview.chromium.org/2240983003/

[sahel, 2016-08-17 14:40:12]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:40:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2016-08-17 14:46:24]

LGTM. Please sync with chongz to decide which of the CLs should go in first.

[commit-bot: I haz the power, 2016-08-17 15:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:41:40]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sahel, 2016-08-17 22:08:16]

I merged the patch with the conflicting one.

https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebInputEvent.h (right):

https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebInputEvent.h:263: static const char*
GetName(WebInputEvent::Type type)
On 2016/08/16 21:02:40, dtapuska wrote:
> Can you move this implementation into the cpp file? That way we won't get
> multiple copies in the different compilation units.

Done.

[sahel, 2016-08-19 14:18:14]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 14:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 15:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 15:14:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sahel, 2016-08-22 21:15:33]

Patchset #6 (id:100001) has been deleted

[sahel, 2016-08-23 17:35:08]

Patchset #6 (id:120001) has been deleted

[sahel, 2016-08-23 17:35:27]

Patchset #5 (id:80001) has been deleted

[mustaq, 2016-08-23 18:29:47]

On 2016/08/17 22:08:16, sahel wrote:
> I merged the patch with the conflicting one.
> 
>
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/WebInputEvent.h (right):
> 
>
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebInputEvent.h:263: static const char*
> GetName(WebInputEvent::Type type)
> On 2016/08/16 21:02:40, dtapuska wrote:
> > Can you move this implementation into the cpp file? That way we won't get
> > multiple copies in the different compilation units.
> 
> Done.

Still LGTM but please take care of the trybot tests.

Any clue why win_clang failed? Is it a one-off failure?

[sahel, 2016-08-23 18:35:44]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 18:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2016-08-23 18:37:21]

On 2016/08/23 18:29:47, mustaq wrote:
> On 2016/08/17 22:08:16, sahel wrote:
> > I merged the patch with the conflicting one.
> > 
> >
>
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> > File third_party/WebKit/public/platform/WebInputEvent.h (right):
> > 
> >
>
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> > third_party/WebKit/public/platform/WebInputEvent.h:263: static const char*
> > GetName(WebInputEvent::Type type)
> > On 2016/08/16 21:02:40, dtapuska wrote:
> > > Can you move this implementation into the cpp file? That way we won't get
> > > multiple copies in the different compilation units.
> > 
> > Done.
> 
> Still LGTM but please take care of the trybot tests.
> 
> Any clue why win_clang failed? Is it a one-off failure?

No, the problem was with using blink_export instead of blink_common_export and
getting warnings in win_clang compilation.

[dtapuska, 2016-08-23 19:04:59]

On 2016/08/23 at 18:37:21, sahel wrote:
> On 2016/08/23 18:29:47, mustaq wrote:
> > On 2016/08/17 22:08:16, sahel wrote:
> > > I merged the patch with the conflicting one.
> > > 
> > >
> >
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> > > File third_party/WebKit/public/platform/WebInputEvent.h (right):
> > > 
> > >
> >
https://codereview.chromium.org/2250233002/diff/1/third_party/WebKit/public/p...
> > > third_party/WebKit/public/platform/WebInputEvent.h:263: static const char*
> > > GetName(WebInputEvent::Type type)
> > > On 2016/08/16 21:02:40, dtapuska wrote:
> > > > Can you move this implementation into the cpp file? That way we won't
get
> > > > multiple copies in the different compilation units.
> > > 
> > > Done.
> > 
> > Still LGTM but please take care of the trybot tests.
> > 
> > Any clue why win_clang failed? Is it a one-off failure?
> 
> No, the problem was with using blink_export instead of blink_common_export and
getting warnings in win_clang compilation.

lgtm

[mustaq, 2016-08-23 20:13:22]

https://codereview.chromium.org/2250233002/diff/140001/content/browser/androi...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2250233002/diff/140001/content/browser/androi...
content/browser/android/content_view_core_impl.cc:991:
blink::WebMouseEvent::ButtonNone,
Looks like you will need to rebase again with the latest ToT. Navid's CL with
Button::NoButton etc are in now.

[commit-bot: I haz the power, 2016-08-23 20:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 20:34:50]

Dry run: This issue passed the CQ dry run.

[mustaq, 2016-08-23 20:35:23]

On 2016/08/23 20:13:22, mustaq wrote:
>
https://codereview.chromium.org/2250233002/diff/140001/content/browser/androi...
> File content/browser/android/content_view_core_impl.cc (right):
> 
>
https://codereview.chromium.org/2250233002/diff/140001/content/browser/androi...
> content/browser/android/content_view_core_impl.cc:991:
> blink::WebMouseEvent::ButtonNone,
> Looks like you will need to rebase again with the latest ToT. Navid's CL with
> Button::NoButton etc are in now.

There's no conflicts, so you don't need another rebase. Sorry for the confusion.

[sahel, 2016-08-23 20:52:35]

sahel@chromium.org changed reviewers:
+ dglazkov@chromium.org, sdefresne@chromium.org, skyostil@chromium.org,
tdresser@chromium.org

[sahel, 2016-08-23 20:52:36]

skyostil@chromium.org: Please review changes in 
content/browser/android/content_view_core_impl.cc 

sdefresne@chromium.org: Please review changes in 
components/test_runner/test_plugin.cc

tdresser@chromium.org: Please review changes in 
content/browser/renderer_host/render_widget_host_unittest.cc
content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

dglazkov@chromium.org: Please review changes in 
third_part/WebKit/Source/*
third_party/WebKit/public/platform/WebInputEvent.h

[tdresser, 2016-08-24 12:56:28]

content/browser/renderer_host/render_widget_host* LGTM.

[Sami, 2016-08-24 13:52:08]

content/browser/android/content_view_core_impl.cc lgtm.

[sahel, 2016-08-24 14:31:04]

Description was changed from

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
==========

to

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
==========

[sahel, 2016-08-24 14:31:04]

sahel@chromium.org changed reviewers:
- sdefresne@chromium.org

[sahel, 2016-08-24 14:34:25]

sahel@chromium.org changed reviewers:
+ dpranke@chromium.org

[sahel, 2016-08-24 14:34:26]

dpranke@chromium.org: Please review changes in

[Dirk Pranke, 2016-08-24 18:03:05]

lgtm

[sahel, 2016-08-24 19:03:51]

The CQ bit was checked by sahel@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:04:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:30:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sahel, 2016-08-25 16:53:49]

The CQ bit was checked by sahel@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:54:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:21:06]

Description was changed from

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
==========

to

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
==========

[commit-bot: I haz the power, 2016-08-25 23:21:08]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-08-25 23:23:20]

Description was changed from

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223
==========

to

==========
Type->String helper function added to WebInputEvent.

WebInputEventTraits::GetName and PageWidgetEventHandler::inputTypeToName cleaned
up.
The helper function is called in TestPlugin::handleInputEvent instead of
re-implementation of the Type->String.
No test is written for this cl.

BUG=594223

Committed: https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c
Cr-Commit-Position: refs/heads/master@{#414580}
==========

[commit-bot: I haz the power, 2016-08-25 23:23:22]

Patchset 5 (id:??) landed as
https://crrev.com/df93225cc0d68727634f91d40e17a9cbe881aa1c
Cr-Commit-Position: refs/heads/master@{#414580}