content/browser/renderer_host/input/input_router_impl.cc - Issue 2250233002: Type->String helper function added to WebInputEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 2250233002: Type->String helper function added to WebInputEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Blink_Common_export instead of blink_export Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/renderer_host/input/gesture_event_queue.cc ('k') | content/browser/renderer_host/input/render_widget_host_latency_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl.cc

diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc

index f846788850de9cd59db33b99817ecfb048881211..61a0cfd53728e44e367c948dccd2ea3483fed937 100644

--- a/content/browser/renderer_host/input/input_router_impl.cc

+++ b/content/browser/renderer_host/input/input_router_impl.cc

@@ -349,10 +349,8 @@ bool InputRouterImpl::Send(IPC::Message* message) {

void InputRouterImpl::FilterAndSendWebInputEvent(

const WebInputEvent& input_event,

const ui::LatencyInfo& latency_info) {

- TRACE_EVENT1("input",

- "InputRouterImpl::FilterAndSendWebInputEvent",

- "type",

- WebInputEventTraits::GetName(input_event.type));

+ TRACE_EVENT1("input", "InputRouterImpl::FilterAndSendWebInputEvent", "type",

+ WebInputEvent::GetName(input_event.type));

TRACE_EVENT_WITH_FLOW2("input,benchmark,devtools.timeline",

"LatencyInfo.Flow",

TRACE_ID_DONT_MANGLE(latency_info.trace_id()),

@@ -523,9 +521,9 @@ void InputRouterImpl::ProcessInputEventAck(WebInputEvent::Type event_type,

const ui::LatencyInfo& latency_info,

uint32_t unique_touch_event_id,

AckSource ack_source) {

- TRACE_EVENT2("input", "InputRouterImpl::ProcessInputEventAck",

- "type", WebInputEventTraits::GetName(event_type),

- "ack", GetEventAckName(ack_result));

+ TRACE_EVENT2("input", "InputRouterImpl::ProcessInputEventAck", "type",

+ WebInputEvent::GetName(event_type), "ack",

+ GetEventAckName(ack_result));

// Note: The keyboard ack must be treated carefully, as it may result in

// synchronous destruction of |this|. Handling immediately guards against