third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2250233002: Type->String helper function added to WebInputEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2250233002: Type->String helper function added to WebInputEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Blink_Common_export instead of blink_export Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « third_party/WebKit/Source/web/WebInputEvent.cpp ('k') | third_party/WebKit/public/platform/WebInputEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 9bc4335ce6d61d0e6cfa6575c8a292b7bff37569..763645a8f0e6b6ceaea8b421f792876fb2f0b6ce 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -1067,7 +1067,7 @@ WebInputEventResult WebViewImpl::handleKeyEvent(const WebKeyboardEvent& event)

|| (event.type == WebInputEvent::KeyDown)

|| (event.type == WebInputEvent::KeyUp));

TRACE_EVENT2("input", "WebViewImpl::handleKeyEvent",

- "type", inputTypeToName(event.type),

+ "type", WebInputEvent::GetName(event.type),

"text", String(event.text).utf8());

// Halt an in-progress fling on a key event.

@@ -2147,7 +2147,7 @@ WebInputEventResult WebViewImpl::handleInputEvent(const WebInputEvent& inputEven

page()->frameHost().visualViewport().startTrackingPinchStats();

- TRACE_EVENT1("input,rail", "WebViewImpl::handleInputEvent", "type", inputTypeToName(inputEvent.type));

+ TRACE_EVENT1("input,rail", "WebViewImpl::handleInputEvent", "type", WebInputEvent::GetName(inputEvent.type));

// If we've started a drag and drop operation, ignore input events until

// we're done.

if (m_doingDragAndDrop)