Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2250203003: Sync XHR on Worker should not crash when response arrives immediately (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fetch-data-loader-for-bytes-consumer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync XHR on Worker should not crash when response arrives immediately A WorkerThreadableLoader::MainThreadLoaderHolder instance is created on the main thread and its reference is sent to the worker thread. The current implementation sends the reference after the loading starts (on the main thread), but it's problematic because the loading may exit immediately and hence it breaks WorkerThreadableLoader::WaitableEventWithTasks's assumption. BUG=637980 Committed: https://crrev.com/4f2cec77114821d5ff05041da5c6d969f6a16ab8 Cr-Commit-Position: refs/heads/master@{#414302}

Patch Set 1 #

Messages

Total messages: 27 (14 generated)
yhirano
4 years, 4 months ago (2016-08-17 03:42:40 UTC) #6
hiroshige
lgtm.
4 years, 4 months ago (2016-08-17 07:48:56 UTC) #7
yhirano
Mike is OOO. Nate, can you take a look?
4 years, 4 months ago (2016-08-22 00:56:08 UTC) #9
yhirano
japhet@: ping
4 years, 4 months ago (2016-08-24 13:33:46 UTC) #11
Nate Chapin
lgtm
4 years, 4 months ago (2016-08-24 16:11:25 UTC) #12
yhirano
Thanks!
4 years, 4 months ago (2016-08-24 17:10:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250203003/1
4 years, 4 months ago (2016-08-24 17:10:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/285759)
4 years, 4 months ago (2016-08-24 18:33:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250203003/1
4 years, 4 months ago (2016-08-25 00:24:41 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/284270)
4 years, 4 months ago (2016-08-25 02:41:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250203003/1
4 years, 4 months ago (2016-08-25 02:55:59 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 03:59:59 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 04:03:21 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f2cec77114821d5ff05041da5c6d969f6a16ab8
Cr-Commit-Position: refs/heads/master@{#414302}

Powered by Google App Engine
This is Rietveld 408576698