Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

Issue 2250203003: Sync XHR on Worker should not crash when response arrives immediately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fetch-data-loader-for-bytes-consumer
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 forwarder = new AsyncTaskForwarder(loaderProxy); 439 forwarder = new AsyncTaskForwarder(loaderProxy);
440 440
441 MainThreadLoaderHolder* mainThreadLoaderHolder = new MainThreadLoaderHolder( forwarder, workerThreadLifecycleContext); 441 MainThreadLoaderHolder* mainThreadLoaderHolder = new MainThreadLoaderHolder( forwarder, workerThreadLifecycleContext);
442 if (mainThreadLoaderHolder->wasContextDestroyedBeforeObserverCreation()) { 442 if (mainThreadLoaderHolder->wasContextDestroyedBeforeObserverCreation()) {
443 // The thread is already terminating. 443 // The thread is already terminating.
444 forwarder->abort(); 444 forwarder->abort();
445 mainThreadLoaderHolder->m_forwarder = nullptr; 445 mainThreadLoaderHolder->m_forwarder = nullptr;
446 return; 446 return;
447 } 447 }
448 mainThreadLoaderHolder->m_workerLoader = workerLoader; 448 mainThreadLoaderHolder->m_workerLoader = workerLoader;
449 forwarder->forwardTask(BLINK_FROM_HERE, createCrossThreadTask(&WorkerThreada bleLoader::didStart, wrapCrossThreadPersistent(workerLoader), wrapCrossThreadPer sistent(mainThreadLoaderHolder)));
449 mainThreadLoaderHolder->start(*toDocument(executionContext), std::move(reque st), options, resourceLoaderOptions); 450 mainThreadLoaderHolder->start(*toDocument(executionContext), std::move(reque st), options, resourceLoaderOptions);
450 forwarder->forwardTask(BLINK_FROM_HERE, createCrossThreadTask(&WorkerThreada bleLoader::didStart, wrapCrossThreadPersistent(workerLoader), wrapCrossThreadPer sistent(mainThreadLoaderHolder)));
451 } 451 }
452 452
453 WorkerThreadableLoader::MainThreadLoaderHolder::~MainThreadLoaderHolder() 453 WorkerThreadableLoader::MainThreadLoaderHolder::~MainThreadLoaderHolder()
454 { 454 {
455 DCHECK(isMainThread()); 455 DCHECK(isMainThread());
456 DCHECK(!m_workerLoader); 456 DCHECK(!m_workerLoader);
457 } 457 }
458 458
459 void WorkerThreadableLoader::MainThreadLoaderHolder::overrideTimeout(unsigned lo ng timeoutMilliseconds) 459 void WorkerThreadableLoader::MainThreadLoaderHolder::overrideTimeout(unsigned lo ng timeoutMilliseconds)
460 { 460 {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 const ResourceLoaderOptions& originalResourceLoaderOptions) 599 const ResourceLoaderOptions& originalResourceLoaderOptions)
600 { 600 {
601 DCHECK(isMainThread()); 601 DCHECK(isMainThread());
602 ResourceLoaderOptions resourceLoaderOptions = originalResourceLoaderOptions; 602 ResourceLoaderOptions resourceLoaderOptions = originalResourceLoaderOptions;
603 resourceLoaderOptions.requestInitiatorContext = WorkerContext; 603 resourceLoaderOptions.requestInitiatorContext = WorkerContext;
604 m_mainThreadLoader = DocumentThreadableLoader::create(document, this, option s, resourceLoaderOptions); 604 m_mainThreadLoader = DocumentThreadableLoader::create(document, this, option s, resourceLoaderOptions);
605 m_mainThreadLoader->start(ResourceRequest(request.get())); 605 m_mainThreadLoader->start(ResourceRequest(request.get()));
606 } 606 }
607 607
608 } // namespace blink 608 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698