third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp - Issue 2250203003: Sync XHR on Worker should not crash when response arrives immediately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

Issue 2250203003: Sync XHR on Worker should not crash when response arrives immediately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fetch-data-loader-for-bytes-consumer

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

index 9a05a18e2fed5100fc884b3434136c9c5f9be9a1..6d528b0cd8f1a48f07fdf9072d62a199493009ff 100644

--- a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

@@ -446,8 +446,8 @@ void WorkerThreadableLoader::MainThreadLoaderHolder::createAndStart(

return;

}

mainThreadLoaderHolder->m_workerLoader = workerLoader;

- mainThreadLoaderHolder->start(*toDocument(executionContext), std::move(request), options, resourceLoaderOptions);

forwarder->forwardTask(BLINK_FROM_HERE, createCrossThreadTask(&WorkerThreadableLoader::didStart, wrapCrossThreadPersistent(workerLoader), wrapCrossThreadPersistent(mainThreadLoaderHolder)));

+ mainThreadLoaderHolder->start(*toDocument(executionContext), std::move(request), options, resourceLoaderOptions);

}

WorkerThreadableLoader::MainThreadLoaderHolder::~MainThreadLoaderHolder()

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | no next file » | no next file with comments »