Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2249873007: Settings: Introduce selectable styling and apply to search engines (Closed)

Created:
4 years, 4 months ago by stevenjb
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, extensions-reviews_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Introduce selectable styling and apply to search engines BUG=638377 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fd2573b67e03eb3cc60ba6b5dbfadf77a08bd331 Cr-Commit-Position: refs/heads/master@{#412896}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Selectable children should be actionable #

Patch Set 5 : Fix test #

Messages

Total messages: 15 (7 generated)
stevenjb
See issue for details.
4 years, 4 months ago (2016-08-16 23:09:36 UTC) #3
stevenjb
ping
4 years, 4 months ago (2016-08-17 20:28:20 UTC) #4
dschuyler
lgtm
4 years, 4 months ago (2016-08-18 00:48:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249873007/60001
4 years, 4 months ago (2016-08-18 15:51:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/280413)
4 years, 4 months ago (2016-08-18 16:43:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249873007/80001
4 years, 4 months ago (2016-08-18 17:25:10 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-18 18:35:33 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 18:37:33 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fd2573b67e03eb3cc60ba6b5dbfadf77a08bd331
Cr-Commit-Position: refs/heads/master@{#412896}

Powered by Google App Engine
This is Rietveld 408576698