Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

Issue 2249873007: Settings: Introduce selectable styling and apply to search engines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
index 40eaede590a73d3e4efad7ef5bb7896da48e888b..e5c8bd00b2bf93bcca7c5113268b86fae513438b 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
@@ -1,9 +1,11 @@
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
+<link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
<link rel="import" href="/search_engines_page/search_engine_entry.html">
<dom-module id="settings-search-engines-list">
<template>
- <style>
+ <style include="cr-shared-style">
.headers {
display: flex;
padding: 10px 0;
@@ -18,7 +20,7 @@
flex: 4.5;
}
- div {
+ div#outer {
margin: var(--search-engines-list-margin);
}
@@ -26,12 +28,15 @@
margin: var(--search-engines-list-item-vertical-space) 0;
}
</style>
- <div>
+ <div id="outer">
<content></content>
- <template is="dom-repeat" items="[[engines]]">
- <settings-search-engine-entry engine="[[item]]">
- </settings-search-engine-entry>
- </template>
+ <iron-list items="[[engines]]" selectable>
+ <template>
+ <settings-search-engine-entry engine="[[item]]"
+ tabindex$="[[tabIndex]]">
+ </settings-search-engine-entry>
+ </template>
+ </iron-list>
</div>
</template>
<script src="search_engines_list.js"></script>

Powered by Google App Engine
This is Rietveld 408576698