chrome/browser/resources/settings/search_engines_page/search_engines_page.html - Issue 2249873007: Settings: Introduce selectable styling and apply to search engines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2249873007: Settings: Introduce selectable styling and apply to search engines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engines_list.html ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

index 9bbea616a3596de1eedf613ddec30ade5bc7798d..0933f290ad13dabb909d43997aab9d1078efc428 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

@@ -44,12 +44,13 @@

<div class="label">$i18n{searchEnginesExtension}</div>

- <div class="extension-engines">

- <template is="dom-repeat" items="[[extensions]]">

- <settings-omnibox-extension-entry engine="[[item]]">

+ <iron-list items="[[extensions]]" class="extension-engines" selectable>

+ <template>

+ <settings-omnibox-extension-entry engine="[[item]]"

+ tabindex$="[[tabIndex]]">

</settings-omnibox-extension-entry>

</template>

- </div>

+ </iron-list>

</template>

</div>

</template>