Fire visualViewport resize event when browser zoomed

Fire visualViewport resize event when browser zoomed

BUG=636421
Committed: https://crrev.com/2ad494069b0447cc2d32c844ce6eb991cc129bd1
Cr-Commit-Position: refs/heads/master@{#417632}

[ymalik, 2016-08-14 22:55:08]

ymalik@chromium.org changed reviewers:
+ bokan@chromium.org

[ymalik, 2016-08-14 22:55:14]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 22:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 00:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 00:24:12]

Dry run: This issue passed the CQ dry run.

[ymalik, 2016-08-15 19:12:48]

ymalik@chromium.org changed reviewers:
+ dtapuska@chromium.org

[ymalik, 2016-08-15 19:12:48]

Sending over to Dave while bokan is away :)

https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:2159:
m_frame->document()->enqueueResizeEvent();
@dtapuska, this is where we send window resize event for the browser zoom. This
is probably where we should send one for the visualViewport as well. We don't
really resize the visual viewport when we browser zoom. If you look at the API,
we always adjust the values before returning (meaning the viewport hasn't really
changed).
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...

[bokan, 2016-08-18 21:18:11]

https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:2159:
m_frame->document()->enqueueResizeEvent();
On 2016/08/15 19:12:48, ymalik wrote:
> @dtapuska, this is where we send window resize event for the browser zoom.
This
> is probably where we should send one for the visualViewport as well. We don't
> really resize the visual viewport when we browser zoom. If you look at the
API,
> we always adjust the values before returning (meaning the viewport hasn't
really
> changed).
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...

Yah, I'm not sure about this. Perhaps it'd be better to add a
didChangePageZoom(float oldZoomFactor) method on VisualViewport and call that
from LocalFrame::setPageAndTextZoomFactors. That way it can calculate if the
width/height actually changed. That or just directly in
setPageAndTextZoomFactors so you can save and compare the clientWidth/Height
before and after.

[bokan, 2016-09-09 16:36:59]

On 2016/08/18 21:18:11, bokan wrote:
>
https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/2249483002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/FrameView.cpp:2159:
> m_frame->document()->enqueueResizeEvent();
> On 2016/08/15 19:12:48, ymalik wrote:
> > @dtapuska, this is where we send window resize event for the browser zoom.
> This
> > is probably where we should send one for the visualViewport as well. We
don't
> > really resize the visual viewport when we browser zoom. If you look at the
> API,
> > we always adjust the values before returning (meaning the viewport hasn't
> really
> > changed).
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...
> 
> Yah, I'm not sure about this. Perhaps it'd be better to add a
> didChangePageZoom(float oldZoomFactor) method on VisualViewport and call that
> from LocalFrame::setPageAndTextZoomFactors. That way it can calculate if the
> width/height actually changed. That or just directly in
> setPageAndTextZoomFactors so you can save and compare the clientWidth/Height
> before and after.

On second thought, these should always change with browser zoom so lgtm.

[ymalik, 2016-09-09 16:39:03]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:09:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 18:10:51]

Description was changed from

==========
Fire visualViewport resize event when browser zoomed

BUG=636421
==========

to

==========
Fire visualViewport resize event when browser zoomed

BUG=636421

Committed: https://crrev.com/2ad494069b0447cc2d32c844ce6eb991cc129bd1
Cr-Commit-Position: refs/heads/master@{#417632}
==========

[commit-bot: I haz the power, 2016-09-09 18:10:52]

Patchset 1 (id:??) landed as
https://crrev.com/2ad494069b0447cc2d32c844ce6eb991cc129bd1
Cr-Commit-Position: refs/heads/master@{#417632}