Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html

Issue 2249483002: Fire visualViewport resize event when browser zoomed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
index 76aa7d305abc0c1de6d985f9b93514a526be08c5..4f057b207789228015b84dd9b24d5f129581258e 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
@@ -18,8 +18,15 @@
return window.visualViewport;
}
+ var numCallsResize = 0;
+
async_test(function(t) {
window.onload = t.step_func(function() {
+
+ window.visualViewport.addEventListener('resize', function(e) {
+ numCallsResize++;
+ });
+
window.scrollTo(100, 100);
// TODO(ymalik): Remove hook to internals to pinch-zoom here and browser
@@ -38,14 +45,19 @@
// Apply browser zoom.
window.internals.setZoomFactor(browserZoomFactor);
- // Visual viewport dimensions should be scaled by the browser zoom factor.
- assert_equals(viewport().scrollTop, 10 / browserZoomFactor);
- assert_equals(viewport().scrollLeft, 10 / browserZoomFactor);
- assert_equals(viewport().clientWidth, 400 / browserZoomFactor);
- assert_equals(viewport().clientHeight, 300 / browserZoomFactor);
- assert_equals(viewport().scale, 2);
-
- t.done();
+ requestAnimationFrame(function() {
+ t.step(function() {
+ assert_equals(numCallsResize, 1, "resize listener called for browzer zoom");
+ // Visual viewport dimensions should be scaled by the browser zoom factor.
+ assert_equals(viewport().scrollTop, 10 / browserZoomFactor);
+ assert_equals(viewport().scrollLeft, 10 / browserZoomFactor);
+ assert_equals(viewport().clientWidth, 400 / browserZoomFactor);
+ assert_equals(viewport().clientHeight, 300 / browserZoomFactor);
+ assert_equals(viewport().scale, 2);
+
+ t.done();
+ });
+ });
});
}, 'Verify viewport dimensions under bowser zoom.');
</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698