Fire visualViewport resize event when browser zoomed

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2135 matching lines @@
     LayoutViewItem layoutViewItem = this->layoutViewItem();
     if (layoutViewItem.isNull() || layoutViewItem.document().printing())
         return;
 
     if (!wasViewportResized())
         return;
 
     m_lastViewportSize = layoutSize(IncludeScrollbars);
     m_lastZoomFactor = layoutViewItem.style()->zoom();
 
+    if (RuntimeEnabledFeatures::visualViewportAPIEnabled())
+        m_frame->document()->enqueueVisualViewportResizeEvent();
+
     m_frame->document()->enqueueResizeEvent();

[ymalik, 2016/08/15 19:12:48]

@dtapuska, this is where we send window resize event for the browser zoom. This
is probably where we should send one for the visualViewport as well. We don't
really resize the visual viewport when we browser zoom. If you look at the API,
we always adjust the values before returning (meaning the viewport hasn't really
changed).
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...

[bokan, 2016/08/18 21:18:11]

Yah, I'm not sure about this. Perhaps it'd be better to add a
didChangePageZoom(float oldZoomFactor) method on VisualViewport and call that
from LocalFrame::setPageAndTextZoomFactors. That way it can calculate if the
width/height actually changed. That or just directly in
setPageAndTextZoomFactors so you can save and compare the clientWidth/Height
before and after.

 
     if (m_frame->isMainFrame())
         InspectorInstrumentation::didResizeMainFrame(m_frame.get());
 }
 
 void FrameView::postLayoutTimerFired(TimerBase*)
 {
     performPostLayoutTasks();
 }
 
@@ skipping 2081 matching lines @@
 }
 
 bool FrameView::canThrottleRendering() const
 {
     if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
         return false;
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 } // namespace blink