Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224943004: Revert "Revert 261654 "Move some extension constants out of //chrome."" (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, tfarina, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert "Revert 261654 "Move some extension constants out of //chrome."" Re-landing the patch from 261654 with a fix for GTK. Revert CL: https://codereview.chromium.org/225103004/ BUG=359173 TBR=asargent@chromium.org TBR=cpu@chromium.org for component_updater header update TBR=avi@chromium.org for tab_contents header update TBR=pkasting@chromium.org for infobars header update Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -314 lines) Patch
M chrome/browser/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/capture_web_contents_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/windows_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +233 lines, -267 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 2 chunks +1 line, -25 lines 0 comments Download
M chrome/common/extensions/extension_icon_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/constants.h View 2 chunks +40 lines, -0 lines 0 comments Download
M extensions/common/constants.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Rockot(use gerrit already)
6 years, 8 months ago (2014-04-04 16:23:27 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r261774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698