chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc - Issue 224943004: Revert "Revert 261654 "Move some extension constants out of //chrome.""

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

Issue 224943004: Revert "Revert 261654 "Move some extension constants out of //chrome."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/api/extension_action/action_info.h"	5 #include "chrome/common/extensions/api/extension_action/action_info.h"

6 #include "chrome/common/extensions/extension_constants.h"

7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"	6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

	7 #include "extensions/common/constants.h"

8 #include "extensions/common/error_utils.h"	8 #include "extensions/common/error_utils.h"

9 #include "extensions/common/extension.h"	9 #include "extensions/common/extension.h"

10 #include "extensions/common/manifest_constants.h"	10 #include "extensions/common/manifest_constants.h"

11 #include "testing/gtest/include/gtest/gtest.h"	11 #include "testing/gtest/include/gtest/gtest.h"

12	12

13 namespace extensions {	13 namespace extensions {

14	14

15 namespace errors = manifest_errors;	15 namespace errors = manifest_errors;

16 namespace keys = manifest_keys;	16 namespace keys = manifest_keys;

17	17

(...skipping 140 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
158 action = LoadAction("page_action_empty_popup.json");	158 action = LoadAction("page_action_empty_popup.json");

159	159

160 ASSERT_TRUE(action);	160 ASSERT_TRUE(action);

161 EXPECT_TRUE(action->default_popup_url.is_empty());	161 EXPECT_TRUE(action->default_popup_url.is_empty());

162 ASSERT_STREQ(	162 ASSERT_STREQ(

163 "",	163 "",

164 action->default_popup_url.spec().c_str());	164 action->default_popup_url.spec().c_str());

165 }	165 }

166	166

167 } // namespace extensions	167 } // namespace extensions

OLD	NEW