chrome/browser/extensions/api/tabs/windows_util.cc - Issue 224943004: Revert "Revert 261654 "Move some extension constants out of //chrome.""

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/tabs/windows_util.cc

Issue 224943004: Revert "Revert 261654 "Move some extension constants out of //chrome."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/capture_web_contents_function.cc ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/tabs/windows_util.h"	5 #include "chrome/browser/extensions/api/tabs/windows_util.h"

6	6

7 #include "base/strings/string_number_conversions.h"	7 #include "base/strings/string_number_conversions.h"

8 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"	8 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"

9 #include "chrome/browser/extensions/chrome_extension_function.h"	9 #include "chrome/browser/extensions/chrome_extension_function.h"

10 #include "chrome/browser/extensions/window_controller.h"	10 #include "chrome/browser/extensions/window_controller.h"

11 #include "chrome/browser/extensions/window_controller_list.h"	11 #include "chrome/browser/extensions/window_controller_list.h"

12 #include "chrome/common/extensions/extension_constants.h"

13 #include "extensions/browser/extension_function_dispatcher.h"	12 #include "extensions/browser/extension_function_dispatcher.h"

	13 #include "extensions/common/constants.h"

14 #include "extensions/common/error_utils.h"	14 #include "extensions/common/error_utils.h"

15	15

16 namespace windows_util {	16 namespace windows_util {

17	17

18 bool GetWindowFromWindowID(ChromeAsyncExtensionFunction* function,	18 bool GetWindowFromWindowID(ChromeAsyncExtensionFunction* function,

19 int window_id,	19 int window_id,

20 extensions::WindowController** controller) {	20 extensions::WindowController** controller) {

21 if (window_id == extension_misc::kCurrentWindowId) {	21 if (window_id == extension_misc::kCurrentWindowId) {

22 extensions::WindowController* extension_window_controller =	22 extensions::WindowController* extension_window_controller =

23 function->dispatcher()->delegate()->GetExtensionWindowController();	23 function->dispatcher()->delegate()->GetExtensionWindowController();

(...skipping 16 matching lines...) Expand all Loading...
40 function->SetError(extensions::ErrorUtils::FormatErrorMessage(	40 function->SetError(extensions::ErrorUtils::FormatErrorMessage(

41 extensions::tabs_constants::kWindowNotFoundError,	41 extensions::tabs_constants::kWindowNotFoundError,

42 base::IntToString(window_id)));	42 base::IntToString(window_id)));

43 return false;	43 return false;

44 }	44 }

45 }	45 }

46 return true;	46 return true;

47 }	47 }

48	48

49 } // namespace windows_util	49 } // namespace windows_util

OLD	NEW