icu local change part1

icu52/source/common/unicode/uconfig.h

Index: icu52/source/common/unicode/uconfig.h
===================================================================
--- icu52/source/common/unicode/uconfig.h	(revision 259715)
+++ icu52/source/common/unicode/uconfig.h	(working copy)
@@ -265,6 +265,14 @@
 #endif
 
 /**
+ * This switch turns off all the converters NOT listed in
+ * the encoding standard : http://encoding.spec.whatwg.org
+ */
+#if UCONFIG_NO_NONHTML5_CONVERSION
+#define UCONFIG_NO_NON_HTML5_CONVERSION 1

[jsbell, 2014/04/04 18:16:20]

It must be intentional, but having these two defines with names that only differ
by _ will be confusing.

(The patch is failing to download so I can't search easily to see where this is
set/used.)

[jungshik at Google, 2014/04/04 22:20:27]

A good catch. Thanks !! Actually, it's a typo. Moreover, I should have used
#ifndef instead of #if. 

More importantly, fixing the typo led me to find more places where I need to use
that check (linker complained about unresolved references). The size reduction
in libicuuc.so is 47kB (I think static linking does not help here and the size
reduction would be comparable in case of static linking). 

+#endif
+
+/**
  * \def UCONFIG_NO_LEGACY_CONVERSION
  * This switch turns off all converters except for
  * - Unicode charsets (UTF-7/8/16/32, CESU-8, SCSU, BOCU-1)