Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3311)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: icu52/source/common/stringpiece.cpp

Issue 224943002: icu local change part1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/
Patch Set: fix typos in uconfig.h and putil.patch Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« icu52/source/common/locmap.c ('K') | « icu52/source/common/putilimp.h ('k') | icu52/source/common/ucmndata.h » ('j') | icu52/source/common/unicode/uconfig.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu52/source/common/stringpiece.cpp
===================================================================
--- icu52/source/common/stringpiece.cpp (revision 259715)
+++ icu52/source/common/stringpiece.cpp (working copy)
@@ -68,6 +68,14 @@
}
+/* Microsft Visual Studios (even 2013) complains about redefinition of this
jsbell 2014/04/04 18:16:20 Typos: "Microsoft Visual Studio" (+o -s) (Or just
jungshik at Google 2014/04/04 22:20:27 Done.
+ * static const class variable. However, the C++ standard states that this
+ * definition is correct. Perhaps there is a bug in the Microsoft compiler.
+ * This is not an issue on any other compilers (that we know of).
+ * Cygwin with MSVC 9.0 also complains here about redefinition.
+ */
+#if (!defined(_MSC_VER) || (_MSC_VER > 1800)) && !defined(CYGWINMSVC)
const int32_t StringPiece::npos = 0x7fffffff;
+#endif
U_NAMESPACE_END
« icu52/source/common/locmap.c ('K') | « icu52/source/common/putilimp.h ('k') | icu52/source/common/ucmndata.h » ('j') | icu52/source/common/unicode/uconfig.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698