icu52/source/common/unicode/uconfig.h - Issue 224943002: icu local change part1

Side by Side Diff: icu52/source/common/unicode/uconfig.h

Issue 224943002: icu local change part1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/

Patch Set: fix typos in uconfig.h and putil.patch Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 **********************************************************************	2 **********************************************************************

3 * Copyright (C) 2002-2013, International Business Machines	3 * Copyright (C) 2002-2013, International Business Machines

4 * Corporation and others. All Rights Reserved.	4 * Corporation and others. All Rights Reserved.

5 **********************************************************************	5 **********************************************************************

6 * file name: uconfig.h	6 * file name: uconfig.h

7 * encoding: US-ASCII	7 * encoding: US-ASCII

8 * tab size: 8 (not used)	8 * tab size: 8 (not used)

9 * indentation:4	9 * indentation:4

10 *	10 *

(...skipping 247 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
258 */	258 */

259 #ifndef UCONFIG_NO_CONVERSION	259 #ifndef UCONFIG_NO_CONVERSION

260 # define UCONFIG_NO_CONVERSION 0	260 # define UCONFIG_NO_CONVERSION 0

261 #endif	261 #endif

262	262

263 #if UCONFIG_NO_CONVERSION	263 #if UCONFIG_NO_CONVERSION

264 # define UCONFIG_NO_LEGACY_CONVERSION 1	264 # define UCONFIG_NO_LEGACY_CONVERSION 1

265 #endif	265 #endif

266	266

267 /**	267 /**

	268 * This switch turns off all the converters NOT listed in

	269 * the encoding standard : http://encoding.spec.whatwg.org

	270 */

	271 #if UCONFIG_NO_NONHTML5_CONVERSION

	272 #define UCONFIG_NO_NON_HTML5_CONVERSION 1
	jsbell 2014/04/04 18:16:20 It must be intentional, but having these two defin It must be intentional, but having these two defines with names that only differ by _ will be confusing. (The patch is failing to download so I can't search easily to see where this is set/used.) jungshik at Google 2014/04/04 22:20:27 A good catch. Thanks !! Actually, it's a typo. Mor Show quoted text On 2014/04/04 18:16:20, jsbell wrote: > It must be intentional, but having these two defines with names that only differ > by _ will be confusing. > > (The patch is failing to download so I can't search easily to see where this is > set/used.) A good catch. Thanks !! Actually, it's a typo. Moreover, I should have used #ifndef instead of #if. More importantly, fixing the typo led me to find more places where I need to use that check (linker complained about unresolved references). The size reduction in libicuuc.so is 47kB (I think static linking does not help here and the size reduction would be comparable in case of static linking).
	273 #endif

	274

	275 /**

268 * \def UCONFIG_NO_LEGACY_CONVERSION	276 * \def UCONFIG_NO_LEGACY_CONVERSION

269 * This switch turns off all converters except for	277 * This switch turns off all converters except for

270 * - Unicode charsets (UTF-7/8/16/32, CESU-8, SCSU, BOCU-1)	278 * - Unicode charsets (UTF-7/8/16/32, CESU-8, SCSU, BOCU-1)

271 * - US-ASCII	279 * - US-ASCII

272 * - ISO-8859-1	280 * - ISO-8859-1

273 *	281 *

274 * Turning off legacy conversion is not possible on EBCDIC platforms	282 * Turning off legacy conversion is not possible on EBCDIC platforms

275 * because they need ibm-37 or ibm-1047 default converters.	283 * because they need ibm-37 or ibm-1047 default converters.

276 *	284 *

277 * @stable ICU 2.4	285 * @stable ICU 2.4

(...skipping 125 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
403 * \def UCONFIG_FORMAT_FASTPATHS_49	411 * \def UCONFIG_FORMAT_FASTPATHS_49

404 * This switch turns on other formatting fastpaths. Binary incompatible in objec t DecimalFormat and DecimalFormatSymbols	412 * This switch turns on other formatting fastpaths. Binary incompatible in objec t DecimalFormat and DecimalFormatSymbols

405 *	413 *

406 * @internal	414 * @internal

407 */	415 */

408 #ifndef UCONFIG_FORMAT_FASTPATHS_49	416 #ifndef UCONFIG_FORMAT_FASTPATHS_49

409 # define UCONFIG_FORMAT_FASTPATHS_49 1	417 # define UCONFIG_FORMAT_FASTPATHS_49 1

410 #endif	418 #endif

411	419

412 #endif	420 #endif

OLD	NEW

« icu52/source/common/stringpiece.cpp ('K') | « icu52/source/common/udata.cpp ('k') | icu52/source/common/unicode/utypes.h » ('j') | icu52/source/data/mappings/convrtrs.txt » ('J')