Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 22493015: Attempt to make it more clear what FloatIntervalSearchAdaptor::collectIfNeeded is doing. (Closed)

Created:
7 years, 4 months ago by eseidel
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Attempt to make it more clear what FloatIntervalSearchAdaptor::collectIfNeeded is doing. It seemed to me that template specifications would be clearer than an if. They also allow for compile-time error checking were a 3rd type of float to come into existance in CSS4. :p For any unfamiliar with this method, this the object used for performing a search on a RedBlackTree in WTF. We create one of these adaptors, specifying that we want to search for values in a specific (logical) Y interval, and this adaptor is called back for any values in the RBTree cooresponding to that interval range. The job of this adaptor is to collect the various values we care about, including the left or right-most offset of the floats in that Y-range as well as what the last (document order) float seen in that range. It also collects the remaining available height for the block but I'm less clear on how that parameter is used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M Source/core/rendering/RenderBlock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +28 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
7 years, 4 months ago (2013-08-09 21:40:58 UTC) #1
eseidel
7 years, 4 months ago (2013-08-09 21:41:18 UTC) #2
ojan
lgtm
7 years, 4 months ago (2013-08-09 22:14:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/22493015/1
7 years, 4 months ago (2013-08-09 22:15:32 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 00:12:55 UTC) #5
Message was sent while issue was closed.
Change committed as 155885

Powered by Google App Engine
This is Rietveld 408576698