DevTools: Make children field of the CpuProfileNode optional in the protocol.

DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947
Committed: https://crrev.com/6bdab9a3cd716bb9e2bc33384e605e068d134d77
Cr-Commit-Position: refs/heads/master@{#413276}

[alph, 2016-08-18 22:55:55]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, paulirish@chromium.org, pfeldman@chromium.org

[alph, 2016-08-18 22:56:32]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 22:57:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 01:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:37:12]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-19 18:44:09]

lgtm

Please attribute to BUG 635947.

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:784: { "name":
"deoptReason", "type": "string", "experimental": true, "description": "The
reason of being not optimized. The function may be deoptimized or marked as
don't optimize."},
This one should be optional as well.

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:785: { "name":
"positionTicks", "type": "array", "items": { "$ref": "PositionTickInfo" },
"experimental": true, "description": "An array of source position ticks." }
And this one maybe?

[alph, 2016-08-19 22:58:27]

Description was changed from

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.
==========

to

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947
==========

[alph, 2016-08-19 22:58:34]

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:784: { "name":
"deoptReason", "type": "string", "experimental": true, "description": "The
reason of being not optimized. The function may be deoptimized or marked as
don't optimize."},
On 2016/08/19 18:44:09, dgozman wrote:
> This one should be optional as well.

I plan to address this in a separate change.

https://codereview.chromium.org/2248963007/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:785: { "name":
"positionTicks", "type": "array", "items": { "$ref": "PositionTickInfo" },
"experimental": true, "description": "An array of source position ticks." }
On 2016/08/19 18:44:09, dgozman wrote:
> And this one maybe?

ditto

[alph, 2016-08-19 22:58:42]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:59:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:04:30]

Description was changed from

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947
==========

to

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947
==========

[commit-bot: I haz the power, 2016-08-19 23:04:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-19 23:05:56]

Description was changed from

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947
==========

to

==========
DevTools: Make children field of the CpuProfileNode optional in the protocol.

BUG=635947

Committed: https://crrev.com/6bdab9a3cd716bb9e2bc33384e605e068d134d77
Cr-Commit-Position: refs/heads/master@{#413276}
==========

[commit-bot: I haz the power, 2016-08-19 23:05:57]

Patchset 1 (id:??) landed as
https://crrev.com/6bdab9a3cd716bb9e2bc33384e605e068d134d77
Cr-Commit-Position: refs/heads/master@{#413276}