third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js - Issue 2248963007: DevTools: Make children field of the CpuProfileNode optional in the protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

Issue 2248963007: DevTools: Make children field of the CpuProfileNode optional in the protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

index f83c2bfbb806a463227f1e1ec428a4716c01e4cf..e42e66f5a8210468f45db59955fbc06fa7af4a83 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

@@ -112,6 +112,8 @@ WebInspector.CPUProfileDataModel.prototype = {

while (sourceNodeStack.length) {

var parentNode = parentNodeStack.pop();

var sourceNode = sourceNodeStack.pop();

+ if (!sourceNode.children)

+ sourceNode.children = [];

var targetNode = new WebInspector.CPUProfileNode(sourceNode, sampleTime);

if (keepNatives || !isNativeNode(sourceNode)) {

parentNode.children.push(targetNode);