Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Issue 2248963007: DevTools: Make children field of the CpuProfileNode optional in the protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "1" }, 2 "version": { "major": "1", "minor": "1" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Runtime", 4 "domain": "Runtime",
5 "description": "Runtime domain exposes JavaScript runtime by means of re mote evaluation and mirror objects. Evaluation results are returned as mirror ob ject that expose object type, string representation and unique identifier that c an be used for further object reference. Original objects are maintained in memo ry unless they are either explicitly released or are released along with the oth er objects in their object group.", 5 "description": "Runtime domain exposes JavaScript runtime by means of re mote evaluation and mirror objects. Evaluation results are returned as mirror ob ject that expose object type, string representation and unique identifier that c an be used for further object reference. Original objects are maintained in memo ry unless they are either explicitly released or are released along with the oth er objects in their object group.",
6 "types": [ 6 "types": [
7 { 7 {
8 "id": "ScriptId", 8 "id": "ScriptId",
9 "type": "string", 9 "type": "string",
10 "description": "Unique script identifier." 10 "description": "Unique script identifier."
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 "experimental": true, 773 "experimental": true,
774 "types": [ 774 "types": [
775 { 775 {
776 "id": "CPUProfileNode", 776 "id": "CPUProfileNode",
777 "type": "object", 777 "type": "object",
778 "description": "CPU Profile node. Holds callsite information, ex ecution statistics and child nodes.", 778 "description": "CPU Profile node. Holds callsite information, ex ecution statistics and child nodes.",
779 "properties": [ 779 "properties": [
780 { "name": "id", "type": "integer", "description": "Unique id of the node." }, 780 { "name": "id", "type": "integer", "description": "Unique id of the node." },
781 { "name": "callFrame", "$ref": "Runtime.CallFrame", "descrip tion": "Function location." }, 781 { "name": "callFrame", "$ref": "Runtime.CallFrame", "descrip tion": "Function location." },
782 { "name": "hitCount", "type": "integer", "description": "Num ber of samples where this node was on top of the call stack." }, 782 { "name": "hitCount", "type": "integer", "description": "Num ber of samples where this node was on top of the call stack." },
783 { "name": "children", "type": "array", "items": { "type": "i nteger" }, "description": "Child node ids." }, 783 { "name": "children", "type": "array", "items": { "type": "i nteger" }, "optional": true, "description": "Child node ids." },
784 { "name": "deoptReason", "type": "string", "experimental": t rue, "description": "The reason of being not optimized. The function may be deop timized or marked as don't optimize."}, 784 { "name": "deoptReason", "type": "string", "experimental": t rue, "description": "The reason of being not optimized. The function may be deop timized or marked as don't optimize."},
dgozman 2016/08/19 18:44:09 This one should be optional as well.
alph 2016/08/19 22:58:34 I plan to address this in a separate change.
785 { "name": "positionTicks", "type": "array", "items": { "$ref ": "PositionTickInfo" }, "experimental": true, "description": "An array of sourc e position ticks." } 785 { "name": "positionTicks", "type": "array", "items": { "$ref ": "PositionTickInfo" }, "experimental": true, "description": "An array of sourc e position ticks." }
dgozman 2016/08/19 18:44:09 And this one maybe?
alph 2016/08/19 22:58:34 ditto
786 ] 786 ]
787 }, 787 },
788 { 788 {
789 "id": "CPUProfile", 789 "id": "CPUProfile",
790 "type": "object", 790 "type": "object",
791 "description": "Profile.", 791 "description": "Profile.",
792 "properties": [ 792 "properties": [
793 { "name": "nodes", "type": "array", "items": { "$ref": "CPUP rofileNode" }, "description": "The list of profile nodes. First item is the root node." }, 793 { "name": "nodes", "type": "array", "items": { "$ref": "CPUP rofileNode" }, "description": "The list of profile nodes. First item is the root node." },
794 { "name": "startTime", "type": "number", "description": "Pro filing start time in seconds." }, 794 { "name": "startTime", "type": "number", "description": "Pro filing start time in seconds." },
795 { "name": "endTime", "type": "number", "description": "Profi ling end time in seconds." }, 795 { "name": "endTime", "type": "number", "description": "Profi ling end time in seconds." },
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
978 { 978 {
979 "name": "heapStatsUpdate", 979 "name": "heapStatsUpdate",
980 "description": "If heap objects tracking has been started then b ackend may send update for one or more fragments", 980 "description": "If heap objects tracking has been started then b ackend may send update for one or more fragments",
981 "parameters": [ 981 "parameters": [
982 { "name": "statsUpdate", "type": "array", "items": { "type": "integer" }, "description": "An array of triplets. Each triplet describes a fra gment. The first integer is the fragment index, the second integer is a total co unt of objects for the fragment, the third integer is a total size of the object s for the fragment."} 982 { "name": "statsUpdate", "type": "array", "items": { "type": "integer" }, "description": "An array of triplets. Each triplet describes a fra gment. The first integer is the fragment index, the second integer is a total co unt of objects for the fragment, the third integer is a total size of the object s for the fragment."}
983 ] 983 ]
984 } 984 }
985 ] 985 ]
986 }] 986 }]
987 } 987 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698