Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
index 169beadc9fc97b9c0c270ec4b2a343425fd87655..88b942292138986d78841cf3901a03879c645b5d 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
@@ -122,9 +122,9 @@ const NSUInteger kMaximumMenuPixelsWide = 300;
chrome::OpenAll(NULL, browser, node, disposition, browser->profile());
- if (disposition == NEW_FOREGROUND_TAB) {
+ if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) {
content::RecordAction(UserMetricsAction("OpenAllBookmarks"));
- } else if (disposition == NEW_WINDOW) {
+ } else if (disposition == WindowOpenDisposition::NEW_WINDOW) {
content::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));
} else {
content::RecordAction(
@@ -144,15 +144,18 @@ const NSUInteger kMaximumMenuPixelsWide = 300;
}
- (IBAction)openAllBookmarks:(id)sender {
- [self openAll:[sender tag] withDisposition:NEW_FOREGROUND_TAB];
+ WindowOpenDisposition disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
+ [self openAll:[sender tag] withDisposition:disposition];
}
- (IBAction)openAllBookmarksNewWindow:(id)sender {
- [self openAll:[sender tag] withDisposition:NEW_WINDOW];
+ WindowOpenDisposition disposition = WindowOpenDisposition::NEW_WINDOW;
+ [self openAll:[sender tag] withDisposition:disposition];
}
- (IBAction)openAllBookmarksIncognitoWindow:(id)sender {
- [self openAll:[sender tag] withDisposition:OFF_THE_RECORD];
+ WindowOpenDisposition disposition = WindowOpenDisposition::OFF_THE_RECORD;
+ [self openAll:[sender tag] withDisposition:disposition];
}
@end // BookmarkMenuCocoaController

Powered by Google App Engine
This is Rietveld 408576698