chrome/browser/ui/browser_navigator_browsertest_chromeos.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

diff --git a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

index e125acbe84a0275649f8ca37d2263a56670ed7a9..3b8bc4b9e27053d7c6a2d3f9953b29b25ed0c848 100644

--- a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

+++ b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

@@ -50,7 +50,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,

// Navigate to the settings page.

chrome::NavigateParams params(MakeNavigateParams(incognito_browser));

- params.disposition = SINGLETON_TAB;

+ params.disposition = WindowOpenDisposition::SINGLETON_TAB;

params.url = GURL("chrome://chrome/settings");

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;

@@ -83,7 +83,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,

// Navigate to the settings page.

chrome::NavigateParams params(MakeNavigateParams(browser()));

- params.disposition = NEW_POPUP;

+ params.disposition = WindowOpenDisposition::NEW_POPUP;

params.url = GURL("chrome://chrome/settings");

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;

@@ -107,7 +107,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,

// Navigate to the settings page.

chrome::NavigateParams params(MakeNavigateParams(browser()));

- params.disposition = NEW_POPUP;

+ params.disposition = WindowOpenDisposition::NEW_POPUP;

params.url = GURL("chrome://chrome/settings");

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;