components/renderer_context_menu/render_view_context_menu_base.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/renderer_context_menu/render_view_context_menu_base.cc

diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc

index 9965772e416fc2ddc8f9606a67b9efd0078de539..708c47e79e571a7ad533d7255ee1b545f5300f6c 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.cc

+++ b/components/renderer_context_menu/render_view_context_menu_base.cc

@@ -391,7 +391,8 @@ void RenderViewContextMenuBase::OpenURLWithExtraHeaders(

content::Referrer(referring_url.GetAsReferrer(),

params_.referrer_policy));

- if (params_.link_url == url && disposition != OFF_THE_RECORD)

+ if (params_.link_url == url &&

+ disposition != WindowOpenDisposition::OFF_THE_RECORD)

params_.custom_context.link_followed = url;

OpenURLParams open_url_params(url, referrer, disposition, transition, false);