ui/base/window_open_disposition.h - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/window_open_disposition.h

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/window_open_disposition.h

diff --git a/ui/base/window_open_disposition.h b/ui/base/window_open_disposition.h

index 74fcfbe11401a8dea4de6c4bf1bb9f37323fea4f..f6dc4fb982128bfe6a8a22996c5c0b003f74e7aa 100644

--- a/ui/base/window_open_disposition.h

+++ b/ui/base/window_open_disposition.h

@@ -9,7 +9,7 @@

// A Java counterpart will be generated for this enum.

// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.ui

Nico 2016/08/30 18:18:39 does GENERATED_JAVA_ENUM_PACKAGE work with enum cl

ncarter (slow) 2016/08/31 17:00:10 Yes, it works (it works with enum struct, too). Th

-enum WindowOpenDisposition {

+enum class WindowOpenDisposition {

UNKNOWN,

CURRENT_TAB,

// Indicates that only one tab with the url should exist in the same window.

@@ -22,7 +22,7 @@ enum WindowOpenDisposition {

OFF_THE_RECORD,

IGNORE_ACTION,

// Update when adding a new disposition.

- WINDOW_OPEN_DISPOSITION_LAST = IGNORE_ACTION

+ MAX_VALUE = IGNORE_ACTION

};

namespace ui {

« no previous file with comments | « ui/base/cocoa/cocoa_base_utils_unittest.mm ('k') | ui/base/window_open_disposition.cc » ('j') | no next file with comments »