Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: components/omnibox/browser/omnibox_edit_unittest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_edit_unittest.cc
diff --git a/components/omnibox/browser/omnibox_edit_unittest.cc b/components/omnibox/browser/omnibox_edit_unittest.cc
index 15cfb3f2c44ff47a9110ed88fd45f6d773d27652..1d4f5d034b10512fbe0191578b1d7c0319eaa1bc 100644
--- a/components/omnibox/browser/omnibox_edit_unittest.cc
+++ b/components/omnibox/browser/omnibox_edit_unittest.cc
@@ -383,14 +383,14 @@ TEST_F(OmniboxEditTest, AlternateNavHasHTTP) {
model()->OnSetFocus(false); // Avoids DCHECK in OpenMatch().
model()->SetUserText(base::ASCIIToUTF16("http://ab cd"));
- model()->OpenMatch(match, CURRENT_TAB, alternate_nav_url, base::string16(),
- 0);
+ model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
+ alternate_nav_url, base::string16(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
client->alternate_nav_match().fill_into_edit));
model()->SetUserText(base::ASCIIToUTF16("ab cd"));
- model()->OpenMatch(match, CURRENT_TAB, alternate_nav_url, base::string16(),
- 0);
+ model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
+ alternate_nav_url, base::string16(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
client->alternate_nav_match().fill_into_edit));
}

Powered by Google App Engine
This is Rietveld 408576698