chrome/browser/ui/views/profiles/profile_chooser_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

index 3bf5e0739eae6f389b5d0a32cc618fa588114ed9..ef490f839b9dd0e9e3f1848f8502fde15b80110e 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -1109,8 +1109,8 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,

open_other_profile_indexes_map_.find(sender);

if (profile_match != open_other_profile_indexes_map_.end()) {

avatar_menu_->SwitchToProfile(

- profile_match->second,

- ui::DispositionFromEventFlags(event.flags()) == NEW_WINDOW,

+ profile_match->second, ui::DispositionFromEventFlags(event.flags()) ==

+ WindowOpenDisposition::NEW_WINDOW,

ProfileMetrics::SWITCH_PROFILE_ICON);

} else {

// This was a profile accounts button.