chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc

diff --git a/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc b/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc

index 7add3fb6e996451481c93b2f094394bbf1a926a6..306c9ecb043f4bce99c42ab274ab975fdddbb1a4 100644

--- a/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc

+++ b/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc

@@ -138,7 +138,7 @@ void ProximityAuthErrorBubbleView::StyledLabelLinkClicked(

if (!web_contents())

return;

- web_contents()->OpenURL(

- content::OpenURLParams(link_url_, content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false));

+ web_contents()->OpenURL(content::OpenURLParams(

+ link_url_, content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false));

}

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | ui/base/window_open_disposition.h » ('J')