Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index 41ea844f4b833ecbdea06ca598afa8a8df9dcdbb..9ba70ea2f733777dfcb6fe32cb7c4fcfef46eabd 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -368,8 +368,9 @@ void OmniboxPopupContentsView::OnMouseReleased(
}
if (event.IsOnlyMiddleMouseButton() || event.IsOnlyLeftMouseButton()) {
- OpenSelectedLine(event, event.IsOnlyLeftMouseButton() ? CURRENT_TAB :
- NEW_BACKGROUND_TAB);
+ OpenSelectedLine(event, event.IsOnlyLeftMouseButton()
+ ? WindowOpenDisposition::CURRENT_TAB
+ : WindowOpenDisposition::NEW_BACKGROUND_TAB);
}
}
@@ -401,7 +402,7 @@ void OmniboxPopupContentsView::OnGestureEvent(ui::GestureEvent* event) {
break;
case ui::ET_GESTURE_TAP:
case ui::ET_GESTURE_SCROLL_END:
- OpenSelectedLine(*event, CURRENT_TAB);
+ OpenSelectedLine(*event, WindowOpenDisposition::CURRENT_TAB);
break;
default:
return;

Powered by Google App Engine
This is Rietveld 408576698