chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 48d9db57742188308090763eed10a4c9e9cdfd3c..7a65b755f2831cb9868d096bca2b345d0163e6b8 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -718,7 +718,9 @@ bool OmniboxViewViews::OnKeyPressed(const ui::KeyEvent& event) {

const bool alt = event.IsAltDown() || event.IsAltGrDown();

switch (event.key_code()) {

case ui::VKEY_RETURN:

- model()->AcceptInput(alt ? NEW_FOREGROUND_TAB : CURRENT_TAB, false);

+ model()->AcceptInput(alt ? WindowOpenDisposition::NEW_FOREGROUND_TAB

+ : WindowOpenDisposition::CURRENT_TAB,

+ false);

return true;

case ui::VKEY_ESCAPE:

return model()->OnEscapeKeyPressed();