Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2248853002: Print error from driver when shader compiler fails (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org, fmenozzi
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Print error from driver when shader compiler fails BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248853002 Committed: https://skia.googlesource.com/skia/+/b42493626763e63426a117b29a74b75af874274b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 4 months ago (2016-08-15 20:11:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248853002/1
4 years, 4 months ago (2016-08-15 20:12:04 UTC) #5
egdaniel
lgtm
4 years, 4 months ago (2016-08-15 20:13:52 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:49:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b42493626763e63426a117b29a74b75af874274b

Powered by Google App Engine
This is Rietveld 408576698