chromecast/browser/metrics/cast_metrics_service_client.cc - Issue 2248793002: Remove OnRecordingDisabled() metrics client interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add helper function Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chromecast/browser/metrics/cast_metrics_service_client.h ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc

index e1f565aba73c8c3eeafe02998fc879176dae4f96..24fdcfcc008a550413610b3c472c2c1c3b750657 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.cc

+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc

@@ -116,9 +116,6 @@ void CastMetricsServiceClient::SetMetricsClientId(

#endif

}

-void CastMetricsServiceClient::OnRecordingDisabled() {

void CastMetricsServiceClient::StoreClientInfo(

const ::metrics::ClientInfo& client_info) {

const std::string& client_id = client_info.client_id;