components/metrics/metrics_service.cc - Issue 2248793002: Remove OnRecordingDisabled() metrics client interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add helper function Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chromecast/browser/metrics/cast_metrics_service_client.cc ('k') | components/metrics/metrics_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index 9513a1efa70e61d9870550a66f8dae7261b24a66..a472188f30ed9a2e822efdca722ea963a7d50573 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -396,8 +396,6 @@ void MetricsService::DisableRecording() {

return;

recording_state_ = INACTIVE;

- client_->OnRecordingDisabled();

base::RemoveActionCallback(action_callback_);

for (MetricsProvider* provider : metrics_providers_)